Get rid of HIR const checker #133321
Get rid of HIR const checker #133321
Conversation
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
|
Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval |
|
I didn't even know we had another const checker... |
|
@wesleywiser, do you have a chance to review this? Otherwise, should I re-roll? (Unless @RalfJung would like to r+ this instead 😸) |
|
@bors r+ rollup=never in case removing this pass changes compiler perf any |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (efdd9e8): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 1.9%, secondary 1.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 767.847s -> 767.333s (-0.07%) |
As far as I can tell, the HIR const checker was implemented in #66170 because we were not able to issue useful const error messages in the MIR const checker.
This seems to have changed in the last 5 years, probably due to work like #90532. I've tweaked the diagnostics slightly and think the error messages have gotten better in fact.
Thus I think the HIR const checker has reached the end of its usefulness, and we can retire it.
cc @RalfJung