Skip to content

Conversation

workingjubilee
Copy link
Member

I tried to make this a PR to the miri repo for funsies. Ironically, the integration flow meant that it would use a too-old toolchain hash, and I didn't understand the build system there enough to want to manually fiddle with the hashes.

@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2024

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I forgot this file even exists... I recently had to allow this lint for a use of Size, I suspect that was due to the other import being used.

@RalfJung
Copy link
Member

RalfJung commented Nov 2, 2024

LGTM, thanks!
r=me when CI is green.

r? @RalfJung

@rustbot rustbot assigned RalfJung and unassigned Mark-Simulacrum Nov 2, 2024
@saethlin
Copy link
Member

saethlin commented Nov 2, 2024

@bors r=RalfJung

@bors
Copy link
Collaborator

bors commented Nov 2, 2024

📌 Commit a953b32 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2024
@bors
Copy link
Collaborator

bors commented Nov 2, 2024

⌛ Testing commit a953b32 with merge 00ed73c...

@bors
Copy link
Collaborator

bors commented Nov 2, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 00ed73c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 2, 2024
@bors bors merged commit 00ed73c into rust-lang:master Nov 2, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 2, 2024
@workingjubilee workingjubilee deleted the update-miri-for-rustc-abi branch November 2, 2024 19:46
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (00ed73c): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -3.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.5% [-3.6%, -3.3%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.5% [-3.6%, -3.3%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.63s -> 780.047s (0.05%)
Artifact size: 335.35 MiB -> 335.36 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants