Rollup of 5 pull requests #132053

matthiaskrgr · 2024-10-23T04:51:26Z

Successful merges:

Run most core::num tests in const context too #131707 (Run most core::num tests in const context too)
abi/compatibility: also test Option-like types #132002 (abi/compatibility: also test Option-like types)
analyse: remove unused uncanonicalized field #132026 (analyse: remove unused uncanonicalized field)
Optimize Rc<T>::default #132031 (Optimize Rc<T>::default)
relnotes: fix stabilizations of assume_init #132040 (relnotes: fix stabilizations of assume_init)

r? @ghost
@rustbot modify labels: rollup

…=thomcc Run most `core::num` tests in const context too This adds some infrastructure for something I was going to use in rust-lang#131566, but it felt worthwhile enough on its own to merge/discuss separately. Essentially, right now we tend to rely on UI tests to ensure that things work in const context, rather than just using library tests. This uses a few simple macro tricks to make it *relatively* painless to execute tests in both runtime and compile-time context. And this only applies to the numeric tests, and not anything else. Recommended to review without whitespace in the diff. cc `@RalfJung`

…=compiler-errors abi/compatibility: also test Option-like types Adds tests for the decision [here](rust-lang#130628 (comment)). Cc ``@workingjubilee``

…compiler-errors analyse: remove unused uncanonicalized field This field is unused and was only relevant when actually printing proof trees. Right now this simply causes proof tree building to leak a bunch of inference vars 😁 r? ``@compiler-errors``

Optimize `Rc<T>::default` The missing piece of rust-lang#131460. Also refactored `Arc<T>::default` by using a safe `NonNull::from(Box::leak(_))` to replace the unnecessarily unsafe call to `NonNull::new_unchecked(Box::into_raw(_))`. The remaining unsafety is coming from `[Rc|Arc]::from_inner`, which is safe from the construction of `[Rc|Arc]Inner`.

relnotes: fix stabilizations of `assume_init` Ref: rust-lang/blog.rust-lang.org#1416

matthiaskrgr · 2024-10-23T04:51:44Z

@bors r+ rollup=never p=5

bors · 2024-10-23T04:51:47Z

📌 Commit b44a0fa has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-10-23T05:57:04Z

⌛ Testing commit b44a0fa with merge 9abfcb4...

bors · 2024-10-23T08:40:17Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 9abfcb4 to master...

rust-timer · 2024-10-23T08:41:43Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#131707	Run most `core::num` tests in const context too	`d16627bf524a8314a9958847736afbb6487dea93` (link)
#132002	abi/compatibility: also test Option-like types	`8b16c5a565cec56cf01c1a10987ceeb34423cc31` (link)
#132026	analyse: remove unused uncanonicalized field	`e038e4cd45a95f5dd01df46f3ff97590074076a7` (link)
#132031	Optimize `Rc<T>::default`	`c581beefaa629b6a042e02b04e3be6dd82073420` (link)
#132040	relnotes: fix stabilizations of `assume_init`	`31061d4dd0241628e30a76215fdcb83dccbacc9d` (link)

previous master: e1f3068995

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-10-23T17:16:10Z

Finished benchmarking commit (9abfcb4): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.3%, 1.8%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.5%, -0.5%]	1
All ❌✅ (primary)	1.0%	[0.3%, 1.8%]	2

Max RSS (memory usage)

Results (primary -2.2%, secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-5.2%	[-5.2%, -5.2%]	1
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-2.2%	[-5.2%, 0.7%]	2

Cycles

Results (primary 1.3%, secondary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	1.3%	[1.3%, 1.3%]	1

Binary size

Results (primary 0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 0.4%]	9
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.0%, 0.4%]	9

Bootstrap: 781.732s -> 782.378s (0.08%)
Artifact size: 333.67 MiB -> 333.72 MiB (0.02%)

Kobzol · 2024-10-29T19:44:13Z

This actually looks like a genuine small regression across the board:

Might have been caused by LLVM doing more work because of #132031? 🤔 Started a perf. run.

Kobzol · 2024-10-30T19:15:18Z

The webrender regression was probably caused by #132031. Anyway, I don't think we need to look into that, as LLVM probably just spends more time optimizing.

@rustbot label: +perf-regression-triaged

clarfonthey and others added 13 commits October 14, 2024 16:37

Run most core::num tests in const context too

362879d

abi/compatibility: also test Option-like types

d567fcc

fix typo

25365ae

remove unused field

d6ce2bd

optimize Rc<T>::default

5b12d90

add codegen test

7782401

refactor Arc<T>::default

0a963ab

relnotes: fix stabilizations of assume_init

1909668

Ref: rust-lang/blog.rust-lang.org#1416

Rollup merge of rust-lang#132002 - RalfJung:abi-compat-option-like, r…

7e1dbae

…=compiler-errors abi/compatibility: also test Option-like types Adds tests for the decision [here](rust-lang#130628 (comment)). Cc ``@workingjubilee``

Rollup merge of rust-lang#132040 - cuviper:assume_init-1.82, r=dtolnay

b44a0fa

relnotes: fix stabilizations of `assume_init` Ref: rust-lang/blog.rust-lang.org#1416

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2024

bors merged commit 9abfcb4 into rust-lang:master Oct 23, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Oct 23, 2024

rustbot added the perf-regression Performance regression. label Oct 23, 2024

rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 30, 2024

matthiaskrgr deleted the rollup-u5ds6i3 branch January 25, 2025 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #132053

Rollup of 5 pull requests #132053

Uh oh!

matthiaskrgr commented Oct 23, 2024

Uh oh!

matthiaskrgr commented Oct 23, 2024

Uh oh!

bors commented Oct 23, 2024

Uh oh!

bors commented Oct 23, 2024

Uh oh!

bors commented Oct 23, 2024

Uh oh!

Uh oh!

rust-timer commented Oct 23, 2024

Uh oh!

rust-timer commented Oct 23, 2024

Uh oh!

Kobzol commented Oct 29, 2024

Uh oh!

Kobzol commented Oct 30, 2024

Uh oh!

Uh oh!

Rollup of 5 pull requests #132053

Rollup of 5 pull requests #132053

Uh oh!

Conversation

matthiaskrgr commented Oct 23, 2024

Uh oh!

matthiaskrgr commented Oct 23, 2024

Uh oh!

bors commented Oct 23, 2024

Uh oh!

bors commented Oct 23, 2024

Uh oh!

bors commented Oct 23, 2024

Uh oh!

Uh oh!

rust-timer commented Oct 23, 2024

Uh oh!

rust-timer commented Oct 23, 2024

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Kobzol commented Oct 29, 2024

Uh oh!

Kobzol commented Oct 30, 2024

Uh oh!

Uh oh!