Sanitizers target modificators #138736

azhogin · 2025-03-20T05:46:50Z

Depends on bool flag fix: #138483.

Some sanitizers need to be target modifiers, and some do not. For now, we should mark all sanitizers as target modifiers except for these: AddressSanitizer, LeakSanitizer

For kCFI, the helper flag -Zsanitizer-cfi-normalize-integers should also be a target modifier.

Many test errors was with sanizer flags inconsistent with std deps. Tests are fixed with -C unsafe-allow-abi-mismatch.

rustbot · 2025-03-20T05:46:56Z

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-03-24T14:46:34Z

Some changes occurred in tests/codegen/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

Some changes occurred in tests/ui/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

bors · 2025-03-26T15:18:09Z

☔ The latest upstream changes (presumably #138974) made this pull request unmergeable. Please resolve the merge conflicts.

BoxyUwU · 2025-03-26T15:50:03Z

r? compiler

Darksonn · 2025-03-27T06:08:55Z

Do we have any tests that check simultaneous use of multiple sanitizers? For example, if I enable both shadow-call-stack and kcfi at the same time, then both must also be enabled in deps.

rcvalle · 2025-04-10T20:08:41Z

@rustbot claim

…t modifiers with custom consistency check function

rustbot · 2025-08-21T09:10:51Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

rcvalle · 2025-08-26T22:49:01Z

@bors retry

rcvalle · 2025-08-29T04:08:52Z

@bors p=1

rcvalle · 2025-09-02T21:33:38Z

@bors r+

bors · 2025-09-02T21:33:41Z

📌 Commit 6d637df has been approved by rcvalle

It is now in the queue for this repository.

bors · 2025-09-02T23:30:33Z

⌛ Testing commit 6d637df with merge c88a42d...

…s, r=rcvalle Sanitizers target modificators Depends on bool flag fix: #138483. Some sanitizers need to be target modifiers, and some do not. For now, we should mark all sanitizers as target modifiers except for these: AddressSanitizer, LeakSanitizer For kCFI, the helper flag -Zsanitizer-cfi-normalize-integers should also be a target modifier. Many test errors was with sanizer flags inconsistent with std deps. Tests are fixed with `-C unsafe-allow-abi-mismatch`.

rust-log-analyzer · 2025-09-03T00:07:31Z

The job x86_64-gnu-llvm-20-3 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests/ui/sanitizer/cfi/no_builtins.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1/bin/rustc" "/checkout/tests/ui/sanitizer/cfi/no_builtins.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitizer/cfi/no_builtins" "-A" "unused" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Clinker-plugin-lto" "-Copt-level=0" "-Zsanitizer=cfi" "-Ctarget-feature=-crt-static" "--crate-type" "rlib"
stdout: none
--- stderr -------------------------------
error: mixing `-Zsanitizer` will cause an ABI mismatch in crate `no_builtins`
##[error]  --> /checkout/tests/ui/sanitizer/cfi/no_builtins.rs:9:1
   |
LL | #![no_builtins]
   | ^
   |
   = help: the `-Zsanitizer` flag modifies the ABI so Rust crates compiled with different values of this flag cannot be used together safely
   = note: `-Zsanitizer=cfi` in this crate is incompatible with unset `-Zsanitizer` in dependency `core`
   = help: unset `-Zsanitizer` in this crate or set `-Zsanitizer=cfi` in `core`
   = help: if you are sure this will not cause problems, you may use `-Cunsafe-allow-abi-mismatch=sanitizer` to silence this error

error: mixing `-Zsanitizer` will cause an ABI mismatch in crate `no_builtins`
##[error]  --> /checkout/tests/ui/sanitizer/cfi/no_builtins.rs:9:1
   |
LL | #![no_builtins]
   | ^
   |
   = help: the `-Zsanitizer` flag modifies the ABI so Rust crates compiled with different values of this flag cannot be used together safely
   = note: `-Zsanitizer=cfi` in this crate is incompatible with unset `-Zsanitizer` in dependency `compiler_builtins`
   = help: unset `-Zsanitizer` in this crate or set `-Zsanitizer=cfi` in `compiler_builtins`
   = help: if you are sure this will not cause problems, you may use `-Cunsafe-allow-abi-mismatch=sanitizer` to silence this error

error: aborting due to 2 previous errors
------------------------------------------

---- [ui] tests/ui/sanitizer/cfi/no_builtins.rs stdout end ----

bors · 2025-09-03T00:08:13Z

💔 Test failed - checks-actions

rcvalle · 2025-09-04T21:15:16Z

This was affected by the test added in #145368. Let's try it again since #145368 had to be reverted and was reverted in #146133.

rcvalle · 2025-09-04T21:15:41Z

@bors r+

bors · 2025-09-04T21:15:44Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: rustdoc-search: yet another stringdex optimization attempt #145911

bors · 2025-09-04T21:15:44Z

📌 Commit 6d637df has been approved by rcvalle

It is now in the queue for this repository.

bors · 2025-09-04T22:51:37Z

⌛ Testing commit 6d637df with merge b3cfb8f...

bors · 2025-09-05T02:00:42Z

☀️ Test successful - checks-actions
Approved by: rcvalle
Pushing b3cfb8f to master...

github-actions · 2025-09-05T02:03:45Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing af00ff2 (parent) -> b3cfb8f (this PR)

Test differences

Show 36 test diffs

Stage 1

[ui] tests/ui/target_modifiers/sanitizer-kcfi-normalize-ints.rs#ok: [missing] -> pass (J5)
[ui] tests/ui/target_modifiers/sanitizer-kcfi-normalize-ints.rs#wrong_flag: [missing] -> pass (J5)
[ui] tests/ui/target_modifiers/sanitizer-kcfi-normalize-ints.rs#wrong_sanitizer: [missing] -> pass (J5)
[ui] tests/ui/target_modifiers/sanitizers-good-for-inconsistency.rs#wrong_address_san: [missing] -> pass (J5)
[ui] tests/ui/target_modifiers/sanitizers-good-for-inconsistency.rs#wrong_leak_san: [missing] -> pass (J5)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#good: [missing] -> pass (J5)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#good_reverted: [missing] -> pass (J5)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#missed_both: [missing] -> pass (J5)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#missed_kcfi: [missing] -> pass (J5)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#missed_safestack: [missing] -> pass (J5)

Stage 2

[ui] tests/ui/target_modifiers/sanitizers-good-for-inconsistency.rs#wrong_leak_san: [missing] -> pass (J0)
[ui] tests/ui/target_modifiers/sanitizer-kcfi-normalize-ints.rs#ok: [missing] -> ignore (ignored on targets without kernel CFI sanitizer) (J1)
[ui] tests/ui/target_modifiers/sanitizer-kcfi-normalize-ints.rs#wrong_flag: [missing] -> ignore (ignored on targets without kernel CFI sanitizer) (J1)
[ui] tests/ui/target_modifiers/sanitizer-kcfi-normalize-ints.rs#wrong_sanitizer: [missing] -> ignore (ignored on targets without kernel CFI sanitizer) (J1)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#good: [missing] -> pass (J2)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#good_reverted: [missing] -> pass (J2)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#missed_both: [missing] -> pass (J2)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#missed_kcfi: [missing] -> pass (J2)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#missed_safestack: [missing] -> pass (J2)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#good: [missing] -> ignore (ignored on targets without SafeStack support) (J3)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#good_reverted: [missing] -> ignore (ignored on targets without SafeStack support) (J3)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#missed_both: [missing] -> ignore (ignored on targets without SafeStack support) (J3)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#missed_kcfi: [missing] -> ignore (ignored on targets without SafeStack support) (J3)
[ui] tests/ui/target_modifiers/sanitizers-safestack-and-kcfi.rs#missed_safestack: [missing] -> ignore (ignored on targets without SafeStack support) (J3)
[ui] tests/ui/target_modifiers/sanitizer-kcfi-normalize-ints.rs#ok: [missing] -> pass (J4)
[ui] tests/ui/target_modifiers/sanitizer-kcfi-normalize-ints.rs#wrong_flag: [missing] -> pass (J4)
[ui] tests/ui/target_modifiers/sanitizer-kcfi-normalize-ints.rs#wrong_sanitizer: [missing] -> pass (J4)
[ui] tests/ui/target_modifiers/sanitizers-good-for-inconsistency.rs#wrong_leak_san: [missing] -> ignore (ignored on targets without leak sanitizer) (J6)
[ui] tests/ui/target_modifiers/sanitizers-good-for-inconsistency.rs#wrong_address_san: [missing] -> pass (J7)
[ui] tests/ui/target_modifiers/sanitizers-good-for-inconsistency.rs#wrong_address_san: [missing] -> ignore (ignored on targets without address sanitizer) (J8)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b3cfb8faf84c5f3b7909479a9f9b6a3290d5f4d7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-linux: 8784.2s -> 5813.9s (-33.8%)
i686-gnu-2: 5343.0s -> 6378.1s (19.4%)
i686-gnu-nopt-1: 7500.0s -> 8746.2s (16.6%)
aarch64-gnu-llvm-19-2: 2238.7s -> 2604.3s (16.3%)
x86_64-gnu-tools: 3305.3s -> 3792.3s (14.7%)
x86_64-gnu-llvm-19: 2393.6s -> 2739.3s (14.4%)
aarch64-gnu-llvm-19-1: 3173.7s -> 3621.8s (14.1%)
dist-apple-various: 3866.7s -> 4312.6s (11.5%)
x86_64-rust-for-linux: 2634.0s -> 2929.7s (11.2%)
i686-gnu-1: 7635.2s -> 8369.9s (9.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-05T04:19:55Z

Finished benchmarking commit (b3cfb8f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[2.3%, 4.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-5.1%, -1.8%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -2.6%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.3%	[4.3%, 4.3%]	1
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.269s -> 467.377s (0.02%)
Artifact size: 390.49 MiB -> 390.50 MiB (0.00%)

rustbot assigned BoxyUwU Mar 20, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 20, 2025