Skip to content

Conversation

workingjubilee
Copy link
Member

Compare: rust-lang/backtrace-rs@230570f...4d7906b

Mostly cleanups and enabling backtraces for the RTEMS target.

r? @ghost

Compare: rust-lang/backtrace-rs@230570f...4d7906b

Mostly cleanups and enabling backtraces for the RTEMS target.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2025
@workingjubilee
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Jan 3, 2025

📌 Commit 6f5fd6d has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2025
@bors
Copy link
Collaborator

bors commented Jan 3, 2025

⌛ Testing commit 6f5fd6d with merge 870c13d...

@bors
Copy link
Collaborator

bors commented Jan 3, 2025

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 870c13d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 3, 2025
@bors bors merged commit 870c13d into rust-lang:master Jan 3, 2025
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Jan 3, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (870c13d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.6% [3.6%, 3.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.1% [-1.4%, 3.6%] 2

Cycles

Results (primary 2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.8% [2.8%, 2.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.8% [2.8%, 2.8%] 1

Binary size

Results (primary 0.1%, secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.1% [0.0%, 0.1%] 12
Regressions ❌
(secondary)
0.1% [0.1%, 0.3%] 38
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [0.0%, 0.1%] 12

Bootstrap: 763.678s -> 763.847s (0.02%)
Artifact size: 325.50 MiB -> 325.57 MiB (0.02%)

@workingjubilee workingjubilee deleted the backtrace-without-ruzstd branch January 3, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants