Document collection From and FromIterator impls that drop duplicate keys.
#134644
Conversation
…te keys. This behavior is worth documenting because there are other plausible alternatives, such as panicking when a duplicate is encountered, and it reminds the programmer to consider whether they should, for example, coalesce duplicate keys first.
|
rustbot has assigned @Mark-Simulacrum. Use |
There was a problem hiding this comment.
You're documenting the order here, this constrains future implementation changes.
And you're sometimes saying values and sometimes entries. That'd be even more constrianing because it means that either only values or keys and values must be replaced, depending on the method used, which can make a difference for keys that are equal but not identical.
|
Good point — I wasn't thinking of an appropriate middle ground between “no comment” and “document the precise behavior”. I have now updated the text so that in all cases it says
which should be broad enough to permit all possible treatments of ordering. |
|
@bors r+ I think this is OK, though the phrasing doesn't feel amazing to me (e.g., implication that duplicate keys are somehow not dropped - we do in fact |
This behavior is worth documenting because there are other plausible alternatives, such as panicking when a duplicate is encountered, and it reminds the programmer to consider whether they should, for example, coalesce duplicate keys first.
Followup to #89869.