Skip to content

Revert "Auto merge of #133809 - mrkajetanp:ci-aarch64-dist, r=Kobzol" #134564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2024
Merged

Revert "Auto merge of #133809 - mrkajetanp:ci-aarch64-dist, r=Kobzol" #134564

merged 1 commit into from
Dec 20, 2024

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Dec 20, 2024

This reverts #133809, as it produced broken aarch64 artifacts (#134563).

@bors p=1

@Kobzol
Revert "Auto merge of rust-lang#133809 - mrkajetanp:ci-aarch64-dist, …
a5dce0e 
…r=Kobzol"

This reverts commit 023521e, reversing
changes made to c434b4b.
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 20, 2024
@Kobzol Kobzol mentioned this pull request Dec 20, 2024
Closed
@nikic
Copy link
Contributor

nikic commented Dec 20, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 20, 2024

📌 Commit a5dce0e has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2024
@jieyouxu
Copy link
Member

@bors p=10 (to get ahead of rollups)

@bors
Copy link
Collaborator

bors commented Dec 20, 2024

⌛ Testing commit a5dce0e with merge bad2aa4...

@bors
Copy link
Collaborator

bors commented Dec 20, 2024

☀️ Test successful - checks-actions
Approved by: nikic
Pushing bad2aa4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 20, 2024
@bors bors merged commit bad2aa4 into rust-lang:master Dec 20, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 20, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bad2aa4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.9% [2.9%, 2.9%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.0% [-0.8%, 2.9%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 767.743s -> 768.054s (0.04%)
Artifact size: 330.26 MiB -> 330.33 MiB (0.02%)

@Urgau Urgau mentioned this pull request Dec 21, 2024
Closed
@Kobzol Kobzol deleted the revert-aarch64-runner branch December 21, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Kobzol @rustbot @nikic @bors @jieyouxu @rust-timer @Mark-Simulacrum