compiletest: properly handle revisioned run-rustfix tests #123601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d042ee9 to
de3857e
Compare
WaffleLapkin
approved these changes
Apr 7, 2024
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (9d5cdf7): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 667.569s -> 665.855s (-0.26%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, if you have a revisioned
//@ run-rustfixtest like//@[foo] run-rustfix, you would run into an error saying crate name cannot contain.characters because the fixed test file trying to be compiled is named<test-name>.<revision>.fixed, from whichrustcinfers the crate name to be<test-name>.<revision>which is not a valid crate name.This PR fixes the problem by constructing a synthetic crate name from
<test-name>.<revision>, by-with_, and.with__and pass that constructed crate name with
--crate-nameto rustc to compile the fixed file.Fixes #123596.