Skip to content

Require Debug for Pointee::Metadata #123181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2024
Merged

Require Debug for Pointee::Metadata #123181

merged 1 commit into from
Mar 31, 2024

Conversation

stepancheg
Copy link
Contributor

Useful for debugging.

@rustbot
Copy link
Collaborator

rustbot commented Mar 29, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 29, 2024
@joboet
Copy link
Member

joboet commented Mar 29, 2024

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 29, 2024
@rustbot rustbot assigned Amanieu and unassigned joboet Mar 29, 2024
@jhpratt
Copy link
Member

jhpratt commented Mar 30, 2024

Diff LGTM, but I'll leave the decision to the team, as that's not my purview.

@Amanieu
Copy link
Member

Amanieu commented Mar 30, 2024

r? @the8472

@rustbot rustbot assigned the8472 and unassigned Amanieu Mar 30, 2024
@the8472
Copy link
Member

the8472 commented Mar 30, 2024

@Amanieu are you sure you got the right person or the right issue? I'm not -api

But since I'm looking at it I might as well comment. The feature is unstable and already requires Hash and Ord which may not be super-trivial so Debug doesn't seem too onerous on top. The only source of doubt I have is that I don't know which additional metadata types we might gain in the future (for custom DSTs? pointers wider than 2 usizes have been discussed somewhere...) and the fewer constraints we impose on those the better, maybe...

@Amanieu
Copy link
Member

Amanieu commented Mar 30, 2024

Sorry I should have clarified. I don't have any opinions on this, but I believe you did some work related to pointer metadata so you may have more context. If you're happy with this, you can just go ahead and merge it.

@the8472
Copy link
Member

the8472 commented Mar 30, 2024 •
edited
Loading

I'm working on niches for usize pointer metadata, which is only vaguely related since it doesn't affect the user-visible types. If you don't see any issues with API forward-compat then sure...

@bors r=the8472,Amanieu rollup

@bors
Copy link
Collaborator

bors commented Mar 30, 2024

📌 Commit b110cb3 has been approved by the8472,Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2024
@bors
Copy link
Collaborator

bors commented Mar 31, 2024

⌛ Testing commit b110cb3 with merge 1aedc96...

@bors
Copy link
Collaborator

bors commented Mar 31, 2024

☀️ Test successful - checks-actions
Approved by: the8472,Amanieu
Pushing 1aedc96 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 31, 2024
@bors bors merged commit 1aedc96 into rust-lang:master Mar 31, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 31, 2024
@bors bors mentioned this pull request Mar 31, 2024
Closed
@stepancheg stepancheg deleted the pointee-metadata-debug branch March 31, 2024 03:10
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1aedc96): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 5.1% [5.1%, 5.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 5.1% [5.1%, 5.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.99s -> 667.618s (-0.21%)
Artifact size: 315.70 MiB -> 315.66 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@the8472 the8472

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
8 participants
@stepancheg @rustbot @joboet @jhpratt @Amanieu @the8472 @bors @rust-timer