Skip to content

Conversation

fee1-dead
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 13, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 13, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@rust-log-analyzer

This comment has been minimized.

|
= note: calls in constant functions are limited to constant functions, tuple structs and tuple variants
= note: expected constant `host`
found constant `true`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The internal name host leaks.

Copy link
Member Author

@fee1-dead fee1-dead Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a known issue for the effects feature, there's a FIXME somewhere for improving this but I haven't had time to work on it yet

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 14, 2023

📌 Commit f441fa0 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2023
@bors
Copy link
Collaborator

bors commented Aug 14, 2023

⌛ Testing commit f441fa0 with merge 475be26...

@bors
Copy link
Collaborator

bors commented Aug 14, 2023

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 475be26 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 14, 2023
@bors bors merged commit 475be26 into rust-lang:master Aug 14, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 14, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (475be26): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-3.1%, -2.6%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 633.099s -> 632.631s (-0.07%)
Artifact size: 346.34 MiB -> 346.50 MiB (0.05%)

@fee1-dead fee1-dead deleted the param-impl-source branch August 17, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants