Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

fee1-dead and others added 12 commits August 7, 2023 05:26
This CL brings the android.md file in-line with the list of supported
targets from platform-support.md.
…+CMSG

This is a 100% race-free way to obtain a child's pidfd while
avoiding `clone3`.
Tracking issue: rust-lang#110998.

The [API guidelines][naming] describe `as` as used for
borrowed -> borrowed operations, and `to_` for
owned -> owned operations on `Copy` types.

[naming]: https://rust-lang.github.io/api-guidelines/naming.html
…imulacrum

open pidfd in child process and send to the parent via SOCK_SEQPACKET+CMSG

This avoids using `clone3` when a pidfd is requested while still getting it in a 100% race-free manner by passing it up from the child process.
This should solve most concerns in rust-lang#82971
…, r=davidtwco

Migrate a trait selection error to use diagnostic translation
fix: not insert missing lifetime for `ConstParamTy`

Fixes rust-lang#113462

We should ignore the missing lifetime, as it's illegal to include a lifetime in a const param.

r? ``@compiler-errors``
…pdate, r=Mark-Simulacrum

Mention riscv64-linux-android support in Android documentation

This CL brings the android.md file in-line with the list of supported targets from platform-support.md.

Followup to rust-lang#112858

r? `@Mark-Simulacrum`
…ons, r=spastorino

Remove old RPITIT tests (revisions were removed)

These tests were not cleaned up after rust-lang#112988.

r? `@spastorino`
…cottmcm

Rename copying `ascii::Char` methods from `as_` to `to_`

Tracking issue: rust-lang#110998.

The [API guidelines][naming] describe `as_` as used for borrowed -> borrowed operations, and `to_` for
owned -> owned operations on `Copy` types.

[naming]: https://rust-lang.github.io/api-guidelines/naming.html
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 9, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Collaborator

bors commented Aug 9, 2023

📌 Commit 83da317 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2023
@bors
Copy link
Collaborator

bors commented Aug 9, 2023

⌛ Testing commit 83da317 with merge 19a647d...

@bors
Copy link
Collaborator

bors commented Aug 9, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 19a647d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 9, 2023
@bors bors merged commit 19a647d into rust-lang:master Aug 9, 2023
@rustbot rustbot added this to the 1.73.0 milestone Aug 9, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#113939 open pidfd in child process and send to the parent via SOCK… 66543664f80a02c113d3c802537276e0ba46f41a (link)
#114548 Migrate a trait selection error to use diagnostic translati… c60114ec1618f395b1680981b99442204866cbc2 (link)
#114606 fix: not insert missing lifetime for ConstParamTy 4aaba27ae486f40cb785ed3100b99c454c58d48f (link)
#114634 Mention riscv64-linux-android support in Android documentat… 126e219e18bff324b41292c264c1fdf8f394a50a (link)
#114638 Remove old RPITIT tests (revisions were removed) 0f3ee0dbe7d05bd4e429c3873c9b579a5a7d751c (link)
#114641 Rename copying ascii::Char methods from as_ to to_ 757c33fbd19626c4a2de5e6ecbc42d5ba485aef1 (link)

previous master: 8838c73e86

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (19a647d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.3% [-5.3%, -5.3%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Bootstrap: 632.915s -> 630.553s (-0.37%)

@matthiaskrgr matthiaskrgr deleted the rollup-xf7qnmn branch March 16, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants