Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/regex
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.8.3
Choose a base ref
...
head repository: rust-lang/regex
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.8.4
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Jun 5, 2023

  1. compile: make Regex::new(r"(?-u:\B)") fail again 

    This regex failed to compile in `regex <1.8`, but the migration to
regex-automata tweaked the rules in a subtle way that permitted it
to compile despite the fact that the old/status-quo matching engines
can't handle it correctly. By that, I mean that they may permit the \B
to match between code units. That in turn results in panicking when
slicing a &str.

In `regex 1.9`, this regex will actually be able to be compiled, but
the matching engines will correctly and robustly never report matches
that split UTF-8 code units. For now, we just add code that causes
`regex 1.8` to have the same behavior as previous releases.

Fixes #1006
    @BurntSushi
    BurntSushi committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    b2ca9c1 View commit details
    Browse the repository at this point in the history

  2. changelog: 1.8.4

    @BurntSushi
    BurntSushi committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    407f6d3 View commit details
    Browse the repository at this point in the history

  3. 1.8.4

    @BurntSushi
    BurntSushi committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    5a34a39 View commit details
    Browse the repository at this point in the history
Loading