Document that parentheses are required for chained comparison operators (RFC 0). #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
operators (RFC 0000).
|
This is my first attempt at a contribution to Rust (yay!), let me know if something is wrong or if you would like the text worded differently. |
src/expressions.md
Outdated
| @@ -436,6 +436,9 @@ operators on standard types is given here. | |||
| : Greater than or equal. | |||
| Calls the `ge` method on the `std::cmp::PartialOrd` trait. | |||
|
|
|||
| Parentheses are required when chaining comparison operators. For example, the | |||
| expression `a == b == c` is invalid and may be written as `((a == b) == c)`. | |||
There was a problem hiding this comment.
could this be (a == b) == c, that is, without the outer parens? In if statements, those outer ones will cause a warning.
There was a problem hiding this comment.
Good catch, it's fixed now.
|
One tiny comment, otherwise, this looks good! Thank you! 😄 |
steveklabnik
approved these changes
Apr 17, 2017
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.