Skip to content

Conversation

maurer
Copy link
Contributor

@maurer maurer commented Feb 2, 2015

I switched the FromStr instances to use Result<a,()> instead of Some as there was no obvious error messages for this kind of parsing (it's just turning strings into enum elements).

The Travis build will fail until a new nightly is created, since it is to deal with breaking changes in rustc.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@TheNeikos
Copy link

The build seems to fail due to Travis not using the latest rust version? I can't explain it any other way.

Perhaps can @maurer resubmit it to make it build again? (If Travis has update that is.)

* Switch FromStr to Result
* Remove "collections" feature from test switch
@maurer
Copy link
Contributor Author

maurer commented Feb 3, 2015

https://travis-ci.org/rust-lang/log/builds/49326475#L136
Seems to be failing due to a dependency failing to build (it appears due to the same issue, different package). I can take a look at the other package if someone else hasn't later today.

@maurer
Copy link
Contributor Author

maurer commented Feb 3, 2015

Neeevermind. I failed to fix the subpackage, only the main "log" package, which is why Travis is failing. (I didn't even notice the subpackage since I wasn't using it)

@maurer
Copy link
Contributor Author

maurer commented Feb 3, 2015

Code passes now.

@alexcrichton
Copy link
Member

Thanks!

alexcrichton added a commit that referenced this pull request Feb 3, 2015
@alexcrichton alexcrichton merged commit f4857cd into rust-lang:master Feb 3, 2015
@maurer maurer deleted the from_str-result branch February 3, 2015 16:50
EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants