Revert loosening of kv cargo features #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the compiled result won't include those wrongly added artifacts in lockfile, but the wrong lockfile still affects some analyze tools? |
|
That is the problem, unfortunately. It wouldn’t be such an issue if it wasn’t for all the existing code depending on |
Thomasdezeeuw
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #661
cc @Thomasdezeeuw @tisonkun
In #657 we moved some
kv_stdcode intokv+std, but this unfortunately has hit a Cargo bug (see #661), which causes ourkvdependencies to always end up in a dependents lockfile. Until the Cargo bug is fixed, or we find a different approach, I think we unfortunately need to revert this.