Skip to content

Fix incorrect lifetime in Value::to_str() #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix incorrect lifetime in Value::to_str() #587

merged 1 commit into from
Oct 9, 2023

Conversation

peterjoel
Copy link
Contributor

Without this change, the following code will not compile:

let foo = record
    .key_values()
    .get(Key::from_str("foo"))
    .and_then(|val| val.to_str());

with the following error:

   |
32 |         .and_then(|val| val.to_str());
   |                         ^^^^^^^^^^^^ returns a reference to data owned by the current function

@Thomasdezeeuw
Copy link
Collaborator

Not really an incorrect lifetime though, the change introduces a broader/larger lifetime.

@peterjoel
Copy link
Contributor Author

Thanks for the fast response!

And yes, incorrect was perhaps a little opinionated! What I meant was: shorter than necessary and likely unintentionally so.

@KodrAus KodrAus merged commit bc5ca09 into rust-lang:master Oct 9, 2023
@KodrAus KodrAus mentioned this pull request Feb 27, 2024
Merged
@cedricschwyter cedricschwyter mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomasdezeeuw Thomasdezeeuw Thomasdezeeuw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterjoel @Thomasdezeeuw @KodrAus