Simplify Display impl #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, `fmt::Display for Error` uses an unusual form `match &self.inner { &Value(ref err) => err.fmt(f), ...}`. It seems `Value(err)` will work just as well.
If this is actually needed, we should add some comment explaining why so
Thomasdezeeuw
approved these changes
Aug 20, 2023
There was a problem hiding this comment.
This code was required in older rustc versions where you had to be explicit about whether you owned the variables (err and msg) or had a reference to them (ref err or ref msg). But the compiler got better at determining this for us, so now we can use cleaner code like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
fmt::Display for Erroruses an unusual formmatch &self.inner { &Value(ref err) => err.fmt(f), ...}. It seemsValue(err)will work just as well.If this is actually needed, we should add some comment explaining why so