Group target_module, path and file arguments
#575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasdezeeuw
approved these changes
Aug 7, 2023
|
OK, I have tested the performance using this code: use criterion::Criterion;
fn log_string_literal(c: &mut Criterion) {
let mut benchmark_group = c.benchmark_group("log string literal");
benchmark_group.bench_function("original", |b| b.iter(|| log::info!("abc")));
benchmark_group.bench_function("optimized", |b| b.iter(|| log_optimized::info!("abc")));
benchmark_group.finish();
}
criterion::criterion_group!(benches, log_string_literal);
criterion::criterion_main!(benches);with the following dependencies in criterion = "*"
log = "*"
log_optimized = { git = "ssh://git@github.com/EFanZh/log.git", branch = "group-target-module-path-and-file", package = "log" }On average, the original one takes 246.84 ps per iteration, and the optimized one takes 245.54 ps per iteration, I consider this difference insignificant. |
NobodyXu
approved these changes
Aug 8, 2023
|
Hi @KodrAus, I’d really appreciate it if you could take a look at this PR. I intend to do some binary size optimizations with ideas from #569. I plan to test and implement each idea with a separate PR, so if this PR gets accepted, I can move on to the next PR. Will these sort of optimizations be accepted? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step of bring optimizations from #569 into the
logcrate.This PR contains two commits:
__private_apimodule so that it is easier to implement more elaborated optimizations.&(target, module_path, file, line)argument into two arguments:&(target, module_path, file)andline. The idea is that a module could have more than one log calls, so most likely, these log calls would have the same(target, module_path, file)triple, group them together will allow multiple log calls to reuse a same(target, module_path, file)instance, see https://godbolt.org/z/z7jW67Ece for comparison.For one of my internal projects, this PR will reduce the binary size by about 2%.
I also tested this PR on
cargo-binstall, this is the test result: