linux: gnu/musl: MAP_32BIT is only defined on x86 #4511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For mk68 and wasm-wali I'm okay to drop this immediately. I think we should give a warning to powerpc users though, could you mark this deprecated instead on that platform? If it's causing test failures, just add it as a skip in |
Even for the |
|
Yes please; that just makes things easier for the time being since the branches remain more in sync (read: fewer conflicts for me to resolve doing cherry picks), it will be easy to delete all deprecated items once we get closer to 1.0. |
077e84e to
6166e51
Compare
|
Should be done now, please double-check the deprecation message |
tgross35
reviewed
Jul 2, 2025
6166e51 to
00ef346
Compare
The Linux kernel only defines MAP_32BIT in the asm/mman.h header on x86. Remove the erraneous definitions for any other architectures on Linux targets. See https://github.com/torvalds/linux/blob/master/arch/x86/include/uapi/asm/mman.h#L5 This makes libc-test somewhat compile on powerpc64le musl. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
00ef346 to
9332d56
Compare
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 29, 2025
The Linux kernel only defines MAP_32BIT in the asm/mman.h header on x86. Remove the erraneous definitions for any other architectures on Linux targets. See https://github.com/torvalds/linux/blob/master/arch/x86/include/uapi/asm/mman.h#L5 This makes libc-test somewhat compile on powerpc64le musl. Signed-off-by: Jens Reidel <adrian@travitia.xyz> (backport <rust-lang#4511>) (cherry picked from commit 9332d56)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
The Linux kernel only defines MAP_32BIT in the asm/mman.h header on x86. Remove the erraneous definitions for any other architectures on Linux targets. See https://github.com/torvalds/linux/blob/master/arch/x86/include/uapi/asm/mman.h#L5 This makes libc-test somewhat compile on powerpc64le musl. Signed-off-by: Jens Reidel <adrian@travitia.xyz> (backport <#4511>) (cherry picked from commit 9332d56)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Linux kernel only defines MAP_32BIT in the asm/mman.h header on x86. Remove the erraneous definitions for any other architectures on Linux targets.
This makes libc-test somewhat compile on powerpc64le musl (except semver, I'll follow up on that as well).
Sources
See https://github.com/torvalds/linux/blob/master/arch/x86/include/uapi/asm/mman.h#L5
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
^ didn't test the other two targets, but this is definitely correct. semver tests only tested for this on x86 already