musl: Decommonize definition of fanotify_event_metadata #4510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
reviewed
Jul 2, 2025
musl has its own definition of the fanotify_event_metadata struct and doesn't use the one from the Linux kernel. The difference here is that musl's mask field has the type unsigned long long, while the kernel uses __u64. This currently causes libc-test to fail to compile on musl targets. Linux: https://github.com/torvalds/linux/blob/master/include/uapi/linux/fanotify.h#L143 musl: https://git.musl-libc.org/cgit/musl/tree/include/sys/fanotify.h#n15 Signed-off-by: Jens Reidel <adrian@travitia.xyz>
ae814fc to
7559ba1
Compare
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 29, 2025
musl has its own definition of the fanotify_event_metadata struct and doesn't use the one from the Linux kernel. The difference here is that musl's mask field has the type unsigned long long, while the kernel uses __u64. This currently causes libc-test to fail to compile on musl targets. Linux: https://github.com/torvalds/linux/blob/master/include/uapi/linux/fanotify.h#L143 musl: https://git.musl-libc.org/cgit/musl/tree/include/sys/fanotify.h#n15 Signed-off-by: Jens Reidel <adrian@travitia.xyz> (backport <rust-lang#4510>) (cherry picked from commit 7559ba1)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
musl has its own definition of the fanotify_event_metadata struct and doesn't use the one from the Linux kernel. The difference here is that musl's mask field has the type unsigned long long, while the kernel uses __u64. This currently causes libc-test to fail to compile on musl targets. Linux: https://github.com/torvalds/linux/blob/master/include/uapi/linux/fanotify.h#L143 musl: https://git.musl-libc.org/cgit/musl/tree/include/sys/fanotify.h#n15 Signed-off-by: Jens Reidel <adrian@travitia.xyz> (backport <#4510>) (cherry picked from commit 7559ba1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
musl has its own definition of the fanotify_event_metadata struct and doesn't use the one from the Linux kernel.
The difference here is that musl's mask field has the type unsigned long long, while the kernel uses __u64.
This currently causes libc-test to fail to compile on musl targets.
Sources
Linux: https://github.com/torvalds/linux/blob/master/include/uapi/linux/fanotify.h#L143
musl: https://git.musl-libc.org/cgit/musl/tree/include/sys/fanotify.h#n15
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI