AIX: Fix the types of 'struct stat'/'struct stat64' fields 'st_*tim' #4597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to add this as a define at https://github.com/xingxue-ibm/libc/blob/a861a0b0cb16dd0cfcb642c3d294fba754cf6df2/libc-test/build.rs#L5470? |
Yeah, I tried that before. Defining |
Thank you! |
|
@rustbot label +stable-nominated |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 11, 2025
(backport <rust-lang#4597>) (cherry picked from commit cf82fdf)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 11, 2025
(backport <rust-lang#4597>) (cherry picked from commit cf82fdf)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 11, 2025
(backport <rust-lang#4597>) (cherry picked from commit cf82fdf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On AIX, when
_ALL_SOURCEis defined, thest_*timfields instruct stat/struct stat64usestruct st_timespec, whereas under POSIX, they usestruct timespec. This patch updates the type to align with the POSIX declaration.Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI