Skip to content

Remove duplicate constant definitions for AIX #4588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

Remove duplicate constant definitions for AIX #4588

merged 1 commit into from
Jul 28, 2025

Conversation

xingxue-ibm
Copy link
Contributor

Description

Remove duplicate constant definitions in src/unix/aix/mod.rs, which is exposed by commit a541bf4.

c_enum! {
   #[repr(u32)]
    pub enum ACTION {
        FIND = 0,
        ENTER,
    }
}
...
// search.h
pub const FIND: c_int = 0;
pub const ENTER: c_int = 1;

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jul 28, 2025
@tgross35 tgross35 added this pull request to the merge queue Jul 28, 2025
Merged via the queue into rust-lang:main with commit bdc4b7d Jul 28, 2025
48 of 52 checks passed
@tgross35
Copy link
Contributor

Just an FYI, your GH account doesn't seem to be linked to your commit email. E.g. https://github.com/rust-lang/libc/commit/bdc4b7df37ec8bbac325ddd6cdba712a0abe3bcd.patch is authored by you, but bdc4b7d doesn't link to your user.

Not a problem of course, just letting you know in case you want to update it :)

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 29, 2025
@tgross35
Remove duplicate constant definitions FIND and ENTER.
8c668fb 
(backport <rust-lang#4588>)
(cherry picked from commit bdc4b7d)
@tgross35 tgross35 mentioned this pull request Jul 29, 2025
Merged
@xingxue-ibm
Copy link
Contributor Author

xingxue-ibm commented Jul 29, 2025 •
edited
Loading

Just an FYI, your GH account doesn't seem to be linked to your commit email. E.g. https://github.com/rust-lang/libc/commit/bdc4b7df37ec8bbac325ddd6cdba712a0abe3bcd.patch is authored by you, but bdc4b7d doesn't link to your user.

Not a problem of course, just letting you know in case you want to update it :)

Thanks for letting me know, fixed it! I was accidentally using the same Git config for both internal and external repositories. 😞

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 11, 2025
@tgross35
Remove duplicate constant definitions FIND and ENTER.
a5b9c30 
(backport <rust-lang#4588>)
(cherry picked from commit bdc4b7d)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 11, 2025
@tgross35
Remove duplicate constant definitions FIND and ENTER.
cee2ba4 
(backport <rust-lang#4588>)
(cherry picked from commit bdc4b7d)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 11, 2025
@tgross35
Remove duplicate constant definitions FIND and ENTER.
fe5a394 
(backport <rust-lang#4588>)
(cherry picked from commit bdc4b7d)
github-merge-queue bot pushed a commit that referenced this pull request Aug 11, 2025
@tgross35
Remove duplicate constant definitions FIND and ENTER.
eed2be9 
(backport <#4588>)
(cherry picked from commit bdc4b7d)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees
No one assigned
Labels
O-unix stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xingxue-ibm @tgross35 @rustbot