Fix the types of constants used for the 'request' argument of ioctl() on AIX #4582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tgross35
reviewed
Jul 26, 2025
libc-test/build.rs
Outdated
| @@ -5593,6 +5593,21 @@ fn test_aix(target: &str) { | |||
| // values because non-unique values are being used which will | |||
| // fail the test when _ALL_SOURCE is defined. | |||
| "EWOULDBLOCK" | "ENOTEMPTY" => true, | |||
|
|
|||
| // These constants are intended for use as the 'int request' argument to 'ioctl()'. | |||
There was a problem hiding this comment.
Could you make this comment FIXME(ctest)? Because if it's an issue that only shows up during tests but not in C, presumably we could do some better validation on our end.
There was a problem hiding this comment.
Could you make this comment
FIXME(ctest)? Because if it's an issue that only shows up during tests but not in C, presumably we could do some better validation on our end.
Good point! Thanks!
ffd8efe to
3c84eb6
Compare
|
I assume this is because BSD and Linux use |
tgross35
approved these changes
Jul 28, 2025
|
@rustbot label +stable-nominated |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 29, 2025
…octl()'. (backport <rust-lang#4582>) (cherry picked from commit 3c84eb6)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
requestargument of theioctl()function has typec_int, but the associated constants were mistakenly defined asc_longdue to an oversight on my part.Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI