Skip to content

Restore struct winsize for AIX #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

Restore struct winsize for AIX #4577

merged 1 commit into from
Jul 25, 2025

Conversation

xingxue-ibm
Copy link
Contributor

Description

This fixes the problem that struct winsize was guarded out for AIX incorrectly.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@collinfunk
Copy link
Contributor

s/Retore/Restore

On AIX and glibc struct winsize are defined in sys/ioctl.h. Most other platforms define it in termios.h. Maybe that is why missed. This change looks good to me though.

@xingxue-ibm xingxue-ibm changed the title Retore struct winsize for AIX Restore struct winsize for AIX Jul 24, 2025
@xingxue-ibm
Copy link
Contributor Author

s/Retore/Restore

On AIX and glibc struct winsize are defined in sys/ioctl.h. Most other platforms define it in termios.h. Maybe that is why missed. This change looks good to me though.

@collinfunk Thank you!

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jul 25, 2025
@tgross35 tgross35 added this pull request to the merge queue Jul 25, 2025
Merged via the queue into rust-lang:main with commit 5c2db83 Jul 25, 2025
48 of 52 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 29, 2025
@tgross35
Retore struct winsize.
b70565e 
(backport <rust-lang#4577>)
(cherry picked from commit e8bb082)
github-merge-queue bot pushed a commit that referenced this pull request Jul 29, 2025
@tgross35
Retore struct winsize.
8cdff91 
(backport <#4577>)
(cherry picked from commit e8bb082)
@tgross35 tgross35 mentioned this pull request Jul 29, 2025
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees
No one assigned
Labels
O-unix stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xingxue-ibm @collinfunk @tgross35 @rustbot