Skip to content

Add 'const' to some signatures for AIX #4563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

Add 'const' to some signatures for AIX #4563

merged 1 commit into from
Jul 23, 2025

Conversation

xingxue-ibm
Copy link
Contributor

Description

The AIX signatures for some non-POSIX functions differ from those on platforms like Linux: some arguments are not marked with the const qualifier, even though they are not modified. To be consistent with other platforms, const is added to the Rust declarations.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@tgross35
Copy link
Contributor

LGTM after cargo fmt.

Were you able to confirm that these are actually fine to be const, or does AIX actually sometimes requite them to be mut for some reason?

@xingxue-ibm
Copy link
Contributor Author

LGTM after cargo fmt.

Were you able to confirm that these are actually fine to be const, or does AIX actually sometimes requite them to be mut for some reason?

Yes, the AIX team confirmed that there should not be an impact if the arguments are declared with const for these API’s in the RUST code.

@xingxue-ibm
Copy link
Contributor Author

I requested AIX to update these signatures with const in AIX headers to help future porting OSS to AIX.

@tgross35
Copy link
Contributor

Could you just run the formatter here for the style check job (and squash)?

I requested AIX to update these signatures with const in AIX headers to help future porting OSS to AIX.

Great, thank you!

@xingxue-ibm xingxue-ibm mentioned this pull request Jul 23, 2025
Closed
2 tasks
@xingxue-ibm
Copy link
Contributor Author

xingxue-ibm commented Jul 23, 2025 •
edited
Loading

Could you just run the formatter here for the style check job (and squash)?

Sorry, I’ve corrected the formatting.

tgross35
tgross35 approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tgross35 tgross35 added this pull request to the merge queue Jul 23, 2025
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jul 23, 2025
Merged via the queue into rust-lang:main with commit 17299d3 Jul 23, 2025
48 of 52 checks passed
@xingxue-ibm
Copy link
Contributor Author

Thank you, @tgross35!

@entd
Copy link

entd commented Jul 25, 2025

Thanks for this work guys.

tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 29, 2025
@tgross35
Add 'const' to signatures to be consistent with other platforms.
d7b6029 
(backport <rust-lang#4563>)
(cherry picked from commit 6af1254)
@tgross35 tgross35 mentioned this pull request Jul 29, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 29, 2025
@tgross35
Add 'const' to signatures to be consistent with other platforms.
0108917 
(backport <#4563>)
(cherry picked from commit 6af1254)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees
No one assigned
Labels
O-unix stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xingxue-ibm @tgross35 @entd @rustbot