Skip to content

Add constants for Memory-Deny-Write-Execute prctls #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

Add constants for Memory-Deny-Write-Execute prctls #4400

merged 1 commit into from
May 3, 2025

Conversation

rusty-snake
Copy link
Contributor

Description

This PR adds constants for Memory-Deny-Write-Execute prctls added in Linux 6.3 (PR_MDWE_NO_INHERIT Linux 6.6).

Sources

https://github.com/torvalds/linux/blob/3bde70a2c82712f05c7220b8b94fc2cbdf7fbfe0/include/uapi/linux/prctl.h#L287-L292

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-linux O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 12, 2025
@rusty-snake rusty-snake mentioned this pull request Apr 12, 2025
Open
5 tasks
@rusty-snake
Copy link
Contributor Author

I'm not sure if the CI failure is because architecture or libc.

@tgross35
Copy link
Contributor

It's probably just that everything in CI running musl is very outdated, I assume they should be available since they are uapi. Cc @maurer in case that is not accurate.

Assuming it's just a CI thing, you can update libc-test/build.rs to skip these on the relevant platform.

@rustbot author

@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rusty-snake rusty-snake force-pushed the prctl-mdwe branch 3 times, most recently from 4cf57ec to b8e262e Compare May 1, 2025 09:30
@rusty-snake
Copy link
Contributor Author

@rustbot ready

tgross35
tgross35 reviewed May 3, 2025
View reviewed changes
@tgross35
Copy link
Contributor

tgross35 commented May 3, 2025

I double checked and Android does look like it defines these https://cs.android.com/android/platform/superproject/main/+/main:bionic/libc/kernel/uapi/linux/prctl.h;l=175-178;drc=7ac54f5c391bf3aeb9fec84a158939421fd8f505

tgross35
tgross35 approved these changes May 3, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tgross35 tgross35 added this pull request to the merge queue May 3, 2025
Merged via the queue into rust-lang:main with commit 76baec6 May 3, 2025
49 of 50 checks passed
@rusty-snake rusty-snake deleted the prctl-mdwe branch May 3, 2025 19:17
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request May 28, 2025
@rusty-snake @tgross35
Add constants for Memory-Deny-Write-Execute prctls
9b90b9f 
(cherry picked from commit 4ed4eb6)
(backport <rust-lang#4400>)
@tgross35 tgross35 mentioned this pull request May 28, 2025
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request May 28, 2025
@rusty-snake @tgross35
Add constants for Memory-Deny-Write-Execute prctls
4759d68 
(cherry picked from commit 4ed4eb6)
(backport <rust-lang#4400>)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request May 28, 2025
@rusty-snake @tgross35
Add constants for Memory-Deny-Write-Execute prctls
eb96214 
(backport <rust-lang#4400>)
(cherry picked from commit 4ed4eb6)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request May 28, 2025
@rusty-snake @tgross35
Add constants for Memory-Deny-Write-Execute prctls
3d942f9 
(backport <rust-lang#4400>)
(cherry picked from commit 4ed4eb6)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jun 1, 2025
DorianNiemiecSVRJS pushed a commit to DorianNiemiecSVRJS/rust-libc that referenced this pull request Jun 21, 2025
@rusty-snake @DorianNiemiecSVRJS
Add constants for Memory-Deny-Write-Execute prctls
ad42fc3 
(backport <rust-lang#4400>)
(cherry picked from commit 4ed4eb6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
O-linux O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rusty-snake @rustbot @tgross35