Skip to content

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jun 16, 2025

Add missing timespec.tv_nsec for gnux32

The tv_nsec field was removed by mistake for gnux32 in bbaa017 ("gnu: Update struct timespec for GNU _TIME_BITS=64").

Fixes #4495

Link: https://github.com/bminor/glibc/blob/d1b27eeda3d92f33314e93537437cab11ddf4777/time/bits/types/struct_timespec.h#L11-L31

[ add referenced commit summary and link to the message - Trevor ]

Copy link
Contributor

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

The tv_nsec field was removed by mistake for gnux32 in bbaa017
("gnu: Update struct timespec for GNU _TIME_BITS=64").

Fixes rust-lang#4495

Link: https://github.com/bminor/glibc/blob/d1b27eeda3d92f33314e93537437cab11ddf4777/time/bits/types/struct_timespec.h#L11-L31

[ add referenced commit summary and link to the message - Trevor ]
@tgross35 tgross35 enabled auto-merge June 17, 2025 07:29
@tgross35 tgross35 added this pull request to the merge queue Jun 17, 2025
Merged via the queue into rust-lang:main with commit 1ba57d4 Jun 17, 2025
50 of 51 checks passed
@tgross35 tgross35 deleted the tv_nsec-fix branch June 17, 2025 08:13
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jun 17, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jun 17, 2025
The tv_nsec field was removed by mistake for gnux32 in bbaa017
("gnu: Update struct timespec for GNU _TIME_BITS=64").

Fixes rust-lang#4495

Link: https://github.com/bminor/glibc/blob/d1b27eeda3d92f33314e93537437cab11ddf4777/time/bits/types/struct_timespec.h#L11-L31

[ add referenced commit summary and link to the message - Trevor ]

(backport <rust-lang#4497>)
(cherry picked from commit e9bd0b4)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jun 17, 2025
The tv_nsec field was removed by mistake for gnux32 in bbaa017
("gnu: Update struct timespec for GNU _TIME_BITS=64").

Fixes rust-lang#4495

Link: https://github.com/bminor/glibc/blob/d1b27eeda3d92f33314e93537437cab11ddf4777/time/bits/types/struct_timespec.h#L11-L31

[ add referenced commit summary and link to the message - Trevor ]

(backport <rust-lang#4497>)
(cherry picked from commit e9bd0b4)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jun 17, 2025
The tv_nsec field was removed by mistake for gnux32 in bbaa017
("gnu: Update struct timespec for GNU _TIME_BITS=64").

Fixes rust-lang#4495

Link: https://github.com/bminor/glibc/blob/d1b27eeda3d92f33314e93537437cab11ddf4777/time/bits/types/struct_timespec.h#L11-L31

[ add referenced commit summary and link to the message - Trevor ]

(backport <rust-lang#4497>)
(cherry picked from commit e9bd0b4)
DorianNiemiecSVRJS pushed a commit to DorianNiemiecSVRJS/rust-libc that referenced this pull request Jun 21, 2025
The tv_nsec field was removed by mistake for gnux32 in bbaa017
("gnu: Update struct timespec for GNU _TIME_BITS=64").

Fixes rust-lang#4495

Link: https://github.com/bminor/glibc/blob/d1b27eeda3d92f33314e93537437cab11ddf4777/time/bits/types/struct_timespec.h#L11-L31

[ add referenced commit summary and link to the message - Trevor ]

(backport <rust-lang#4497>)
(cherry picked from commit e9bd0b4)
@tgross35 tgross35 mentioned this pull request Jul 29, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-gnu O-linux O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tv_nsec field of struct timespec removed for x86_64-unknown-linux-gnux32 platforms?
4 participants