make pidfd_info fields pub #4487
Merged
+15
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering that this is also hitting freebsd I think those failures are unrelated. |
tgross35
approved these changes
Jun 15, 2025
the struct appers to be extensible, so also mark it as non_exhaustive
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 17, 2025
the struct appers to be extensible, so also mark it as non_exhaustive (backport <rust-lang#4487>) (cherry picked from commit 4dc50eb)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 17, 2025
the struct appers to be extensible, so also mark it as non_exhaustive (backport <rust-lang#4487>) (cherry picked from commit 4dc50eb)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 17, 2025
the struct appers to be extensible, so also mark it as non_exhaustive (backport <rust-lang#4487>) (cherry picked from commit 4dc50eb)
DorianNiemiecSVRJS
pushed a commit
to DorianNiemiecSVRJS/rust-libc
that referenced
this pull request
Jun 21, 2025
the struct appers to be extensible, so also mark it as non_exhaustive (backport <rust-lang#4487>) (cherry picked from commit 4dc50eb)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This marks the fields of
pidfd_infopub.This seems to have been an oversight, most of the other fields in module are also pub. I also mark it as non_exhaustive since the struct is extensible, new fields have been added recently.
Sources
https://github.com/torvalds/linux/blob/19272b37aa4f83ca52bdf9c16d5d81bdd1354494/include/uapi/linux/pidfd.h#L109-L110
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI
@rustbot label +stable-nominated