Skip to content

android: Add getauxval for 32-bit targets #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2025
Merged

android: Add getauxval for 32-bit targets #4338

merged 1 commit into from
Mar 22, 2025

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Mar 18, 2025

Description

getauxval has been added in Android 4.3 (API level 18). (Since Rust 1.68, std requires API level 19+)

(On Android, getauxval is currently only provided for 64-bit targets #1991)

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Mar 18, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 18, 2025

Some changes occurred in the Android module

cc @maurer

This was referenced Mar 18, 2025
Merged
Merged
maurer
maurer approved these changes Mar 19, 2025
View reviewed changes
Copy link

@maurer maurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Android

tgross35
tgross35 approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 22, 2025
@tgross35 tgross35 added this pull request to the merge queue Mar 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 22, 2025
@tgross35 tgross35 added this pull request to the merge queue Mar 22, 2025
Merged via the queue into rust-lang:main with commit ceb72f6 Mar 22, 2025
43 checks passed
@taiki-e taiki-e deleted the android-32-getauxval branch March 22, 2025 04:27
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
@taiki-e @tgross35
android: Add getauxval for 32-bit targets
de18637 
(backport <rust-lang#4338>)
(cherry picked from commit a42eea3)
@tgross35 tgross35 mentioned this pull request Apr 3, 2025
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 4, 2025
@taiki-e taiki-e mentioned this pull request Apr 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

+1 more reviewer

@maurer maurer maurer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tgross35 tgross35

Labels
O-android O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taiki-e @rustbot @maurer @tgross35