Add timerfd APIs for illumos and NetBSD. #4333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
requested changes
Mar 22, 2025
src/unix/solarish/illumos.rs
Outdated
| @@ -353,4 +359,13 @@ extern "C" { | |||
| n: size_t, | |||
| loc: crate::locale_t, | |||
| ) -> c_int; | |||
|
|
|||
| pub fn timerfd_create(clockid: crate::clockid_t, flags: c_int) -> c_int; | |||
There was a problem hiding this comment.
The illumos sources look like (c_int, c_int) here. I assume clockid_t is the same type but we should probably be consistent.
There was a problem hiding this comment.
Yeah, it's a Linux compatibility interface so the signature was intentionally borrowed from what they were doing
844d6b0 to
78d9f2e
Compare
illumos and NetBSD >= 10 support Linux-compatble timerfd APIs. This is based on the headers for [illumos] and [NetBSD]. [illumos]: https://code.illumos.org/plugins/gitiles/illumos-gate/+/refs/heads/master/usr/src/uts/common/sys/timerfd.h#34 [NetBSD]: https://nxr.netbsd.org/xref/src/sys/sys/timerfd.h#44
78d9f2e to
b2b1702
Compare
|
Squashed and rebased. The CI failure is probably unrelated because this PR doesn't touch any FreeBSD code. |
|
Thanks! Yeah that job has spurious failures. |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Apr 3, 2025
illumos and NetBSD >= 10 support Linux-compatble timerfd APIs. This is based on the headers for [illumos] and [NetBSD]. [illumos]: https://code.illumos.org/plugins/gitiles/illumos-gate/+/refs/heads/master/usr/src/uts/common/sys/timerfd.h#34 [NetBSD]: https://nxr.netbsd.org/xref/src/sys/sys/timerfd.h#44 (backport <rust-lang#4333>) (cherry picked from commit b2b1702)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add timerfd APIs for illumos and NetBSD.
illumos and NetBSD >= 10 support Linux-compatble timerfd APIs.
Sources
This is based on the headers for illumos and NetBSD.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI