Add more redox sys/socket.h and sys/uio.h definitions #4388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
reviewed
Apr 10, 2025
| pub msg_iov: *mut crate::iovec, | ||
| pub msg_iovlen: size_t, | ||
| pub msg_control: *mut c_void, | ||
| pub msg_controllen: size_t, |
There was a problem hiding this comment.
From the linked source, should this also be socklen_t?
There was a problem hiding this comment.
This has been corrected in relibc with https://gitlab.redox-os.org/redox-os/relibc/-/commit/27f3924126f931f63659f5464f3b1d76a4123e09
tgross35
reviewed
Apr 10, 2025
| } | ||
|
|
||
| pub struct cmsghdr { | ||
| pub cmsg_len: size_t, |
There was a problem hiding this comment.
This has been corrected in relibc with https://gitlab.redox-os.org/redox-os/relibc/-/commit/27f3924126f931f63659f5464f3b1d76a4123e09
|
The android test failed, I don't think it is because of my changes. |
|
The android tests have been very flaky, I don't know why. Restarted. |
|
Will this change go to the 0.2 branch as well? |
|
It will, I cherry pick everything labeled |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Apr 11, 2025
(backport <rust-lang#4388>) (cherry picked from commit a27b5a6)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Apr 11, 2025
(backport <rust-lang#4388>) (cherry picked from commit a27b5a6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the following definitions for Redox OS
Structs:
Functions:
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI