Skip to content

Fixes for NuttX target #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 31, 2024
Merged

Fixes for NuttX target #4222

merged 2 commits into from
Dec 31, 2024

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Dec 26, 2024

Description

Some fixes for NuttX target:

  • Add pw_passwd field to struct passwd
  • update type of tm_zone/d_name to use c_char type

Sources

src/unix/nuttx/mod.rs

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@no1wudi
feat: add pw_passwd field to passwd struct in NuttX
ec9ea22 
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
@no1wudi
fix: update tm_zone and d_name fields to use c_char type in NuttX
cb668df 
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

Sources

src/unix/nuttx/mod.rs

For future reference, this is meant to be links to the C source files to cross reference :) but I found these at https://github.com/apache/nuttx/blob/f344a422e8ca8cea6eb31812c1a00fccb7a6d392/include/pwd.h#L49, https://github.com/apache/nuttx/blob/f344a422e8ca8cea6eb31812c1a00fccb7a6d392/include/time.h#L121, https://github.com/apache/nuttx/blob/f344a422e8ca8cea6eb31812c1a00fccb7a6d392/include/dirent.h#L113, looks consistent to me.

@rustbot labeled +stable-nominated

@tgross35 tgross35 added this pull request to the merge queue Dec 31, 2024
Merged via the queue into rust-lang:main with commit da95caa Dec 31, 2024
45 checks passed
@no1wudi no1wudi mentioned this pull request Jan 9, 2025
Merged
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 10, 2025
@no1wudi no1wudi mentioned this pull request Mar 10, 2025
Merged
3 tasks
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@no1wudi @tgross35
feat: add pw_passwd field to passwd struct in NuttX
3afb584 
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>

(backport <rust-lang#4222>)
(cherry picked from commit ec9ea22)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@no1wudi @tgross35
fix: update tm_zone and d_name fields to use c_char type in NuttX
3b440cb 
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>

(backport <rust-lang#4222>)
(cherry picked from commit cb668df)
@tgross35 tgross35 mentioned this pull request Mar 10, 2025
Merged
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@no1wudi @tgross35
feat: add pw_passwd field to passwd struct in NuttX
df22514 
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>

(backport <rust-lang#4222>)
(cherry picked from commit ec9ea22)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Mar 10, 2025
@no1wudi @tgross35
fix: update tm_zone and d_name fields to use c_char type in NuttX
80adb61 
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>

(backport <rust-lang#4222>)
(cherry picked from commit cb668df)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Mar 10, 2025
This was referenced Mar 10, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels
O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@no1wudi @rustbot @tgross35