Remove pthread_set_name_np from NuttX #4251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
approved these changes
Jan 27, 2025
|
LGTM, blocked on #4254 for CI fixes. |
Removed `pthread_set_name_np` function from the NuttX bindings as it does not exist in the NuttX API, this change aligns the code with the actual NuttX implementation Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
auto-merge was automatically disabled
February 5, 2025 11:44
Pull Request is not mergeable
|
I only noticed these two when doing a scan for PRs without a |
Thanks, get it. |
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
Removed `pthread_set_name_np` function from the NuttX bindings as it does not exist in the NuttX API, this change aligns the code with the actual NuttX implementation Signed-off-by: Huang Qi <huangqi3@xiaomi.com> (backport <rust-lang#4251>) (cherry picked from commit f4ab0b1)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
Removed `pthread_set_name_np` function from the NuttX bindings as it does not exist in the NuttX API, this change aligns the code with the actual NuttX implementation Signed-off-by: Huang Qi <huangqi3@xiaomi.com> (backport <rust-lang#4251>) (cherry picked from commit f4ab0b1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed
pthread_set_name_npfunction from the NuttX bindings as it does not exist in the NuttX API, this change aligns the code with the actual NuttX implementationSources
https://github.com/apache/nuttx/blob/8f3a2a6f7645dd95b6a7608b9cde3cb693b118c2/include/pthread.h#L511-L514
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI