Skip to content

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Nov 25, 2024

@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2024

Some changes occurred in solarish module

cc @jclulow, @pfmooney

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine but please include header links.

Cc @psumbera for Solaris

@devnexen
Copy link
Contributor Author

@rustbot stable-nominated

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Nov 25, 2024
@bors
Copy link
Contributor

bors commented Nov 27, 2024

☔ The latest upstream changes (presumably #4132) made this pull request unmergeable. Please resolve the merge conflicts.

@tgross35 tgross35 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into rust-lang:main with commit e1d85d5 Nov 27, 2024
45 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Nov 28, 2024
@tgross35 tgross35 mentioned this pull request Nov 28, 2024
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-solarish O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants