Skip to content

feat: replace manual copy loop with rust-provided function #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat: replace manual copy loop with rust-provided function #456

merged 1 commit into from
Feb 13, 2025

Conversation

CosminPerRam
Copy link
Contributor

Way quicker on debug builds, only a condition and a jump better on release (godbolt here), I find it to be simpler than the for alternative.

Byron
Byron approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thank you!
That's a real performance improvement right here!

@Byron Byron merged commit c675117 into rust-lang:main Feb 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CosminPerRam @Byron