Flag another curl error as possibly spurious #9695
Conversation
|
r? @Eh2406 (rust-highfive has picked a reviewer for you, use r? to override) |
|
Do you have any sense why this would start occurring? Is it certain this is related to the update to curl-sys? |
|
No idea myself unfortunately, although it does seems highly related. Not that I know why :( |
|
Ok I debugged some more, and I think we still want to land this to help mitigate the impact on nightly in the short-term ideally. |
|
Ok, sounds good. I haven't tested this myself, but I'll assume it will help. I'll try to push it out to nightly quickly. @bors r+ |
|
📌 Commit 5d7a2b8 has been approved by |
|
☀️ Test successful - checks-actions |
Update cargo 6 commits in 66a6737a0c9f3a974af2dd032a65d3e409c77aac..27277d966b3cfa454d6dea7f724cb961c036251c 2021-07-14 20:54:28 +0000 to 2021-07-16 00:50:39 +0000 - Flag another curl error as possibly spurious (rust-lang/cargo#9695) - Add `d` as an alias for `doc` (rust-lang/cargo#9680) - `cargo fix --edition`: extend warning when on latest edition (rust-lang/cargo#9694) - Update env_logger requirement from 0.8.1 to 0.9.0 (rust-lang/cargo#9688) - Document cargo limitation w/ workspaces & configs (rust-lang/cargo#9674) - Change some warnings to errors (rust-lang/cargo#9689)
|
@ehuss @alexcrichton will this fix be included in rust 1.54? Or we'll have to wait for another 6 weeks for 1.55? |
|
It shouldn't be necessary for 1.54, as the regression (rust-lang/rust#86874) was introduced in 1.55. Are you seeing problems with 1.54? |
We at Void Linux see this issue in |
|
Are you using a custom build of Cargo using a different version of libcurl? If so, what is the exact version? |
|
On Sun, 2021-08-01 at 10:39 -0700, Eric Huss wrote:
Are you using a custom build of Cargo using a different version of
libcurl? If so, what is the exact version?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
We use cargo 0.54.0 with curl 7.78.0
|
|
Ah. I believe you will need to revert to curl 7.76, or wait for Rust 1.55. |
Most likely we won't revert our curl because of possible CVE fixes between those 2 releases. Maybe we will patch out the part which causes issues. |
See rust-lang/cargo#9695 Closes #83977. Signed-off-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
This is a slightly speculative fix based on https://github.community/t/189130 and rust-lang/cargo#9695. Although it seems this may have been fixed/worked around in cargo, the latest version of `cargo-udeps` still depends on cargo 0.54.0 which could be affected.
cc rust-lang/crates.io#3782