Skip to content

Fixed a needless borrow. #8130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2020
Merged

Fixed a needless borrow. #8130

merged 1 commit into from
Apr 19, 2020

Conversation

hbina
Copy link
Contributor

@hbina hbina commented Apr 18, 2020 •
edited
Loading

Mentioned by rust-clippy.

@rust-highfive
Copy link

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2020
@hbina
Copy link
Contributor Author

hbina commented Apr 19, 2020

The build failed because of unrelated errors. Is there a way to restart them?

Starting: Install rust
==============================================================================
Task         : Bash
Description  : Run a Bash script on macOS, Linux, or Windows
Version      : 3.163.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /home/vsts/work/_temp/689d94b6-174e-48bf-9588-24198a94e3e8.sh
info: profile set to 'minimal'
error: toolchain 'nightly-x86_64-unknown-linux-gnu' is not installed
already removed
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: update not yet available, sorry! try again later

  nightly-x86_64-unknown-linux-gnu unchanged - (toolchain not installed)

error: toolchain 'nightly-x86_64-unknown-linux-gnu' is not installed

##[error]Bash exited with code '1'.
Finishing: Install rust

@ehuss
Copy link
Contributor

ehuss commented Apr 19, 2020

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Apr 19, 2020

📌 Commit fb48de8 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2020
@bors
Copy link
Contributor

bors commented Apr 19, 2020

⌛ Testing commit fb48de8 with merge 235beb0...

@bors
Copy link
Contributor

bors commented Apr 19, 2020

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing 235beb0 to master...

@bors bors merged commit 235beb0 into rust-lang:master Apr 19, 2020
@hbina hbina deleted the needless_borrow branch April 19, 2020 18:22
@ehuss ehuss mentioned this pull request Apr 21, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2020
@bors
Auto merge of rust-lang#71402 - ehuss:update-cargo, r=ehuss
70f4f32 
Update cargo, rls

## cargo

17 commits in ebda5065ee8a1e46801380abcbac21a25bc7e755..8751eb3010d4cdb5329b5a6bd2b6d765c95b0dca
2020-04-16 14:28:43 +0000 to 2020-04-21 18:04:35 +0000
- Uplift windows gnu DLL import libraries. (rust-lang/cargo#8141)
- Add windows-gnu CI and fix tests (rust-lang/cargo#8139)
- Several updates to token/index handling. (rust-lang/cargo#7973)
- Add `resolver` opt-in for new feature resolver. (rust-lang/cargo#8129)
- Improve error message when running `cargo install .` (rust-lang/cargo#8137)
- fix mem replace unused (rust-lang/cargo#8138)
- Change `-Cembed-bitcode=no` use to `-Cbitcode-in-rlib=no`. (rust-lang/cargo#8134)
- Refactor BuildContext (rust-lang/cargo#8068)
- Rename allows_underscores to allows_dashes. (rust-lang/cargo#8135)
- Fixed a needless borrow. (rust-lang/cargo#8130)
- Add link to changelog in the Cargo book. (rust-lang/cargo#8126)
- Fix target for doc test cross compilation (rust-lang/cargo#8094)
- Add note about .cargo/config support. (rust-lang/cargo#8125)
- Fix pdb uplift when executable has dashes. (rust-lang/cargo#8123)
- Hint upgrading for future edition keys (rust-lang/cargo#8122)
- Use some fs shorthand functions. (rust-lang/cargo#8124)
- Update documentation to mention "config.toml" instead of "config" (rust-lang/cargo#8121)

## rls

1 commits in 2659cbf14bfb0929a16d7ce9b6858d0bb286ede7..7de2a1f299f8744ffe109139f9f1fdf28bfec909
2020-04-14 22:07:24 +0200 to 2020-04-19 22:41:55 +0000
- Update cargo (rust-lang/rls#1663)
@ehuss ehuss added this to the 1.45.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.45.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hbina @rust-highfive @ehuss @bors