Skip to content

Conversation

alexcrichton
Copy link
Member

ehuss and others added 2 commits September 24, 2019 10:54
Integration tests were waiting for binaries to finish building due to a minor
logic error.
Fixes an accidental regression from rust-lang#7084 where `--features a b` was
erroneously mistinterpreted as `--features "a b"`.

Closes rust-lang#7418
@rust-highfive
Copy link

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.39.0. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2019
@alexcrichton
Copy link
Member Author

r? @ehuss

@rust-highfive rust-highfive assigned ehuss and unassigned nrc Sep 24, 2019
@ehuss
Copy link
Contributor

ehuss commented Sep 24, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Sep 24, 2019

📌 Commit f393130 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2019
bors added a commit that referenced this pull request Sep 24, 2019
[beta] Backport two changes to 1.39.0

This is a backport of:

* #7394
* #7419
@bors
Copy link
Contributor

bors commented Sep 24, 2019

⌛ Testing commit f393130 with merge 7d1d5fd...

@bors
Copy link
Contributor

bors commented Sep 24, 2019

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing 7d1d5fd to rust-1.39.0...

@bors bors merged commit f393130 into rust-lang:rust-1.39.0 Sep 24, 2019
@bors bors deleted the beta-next branch September 24, 2019 18:47
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 25, 2019
2 commits in b6c6f685b38d523580813b0031677c2298f458ea..4b105b6abfb12d6985ffe66670e8b2a85982291a
2019-09-19 21:10:09 +0000 to 2019-09-25 17:26:54 +0000
- [beta] Don't ever capture CPU state if timings are disabled (rust-lang/cargo#7430)
- [beta] Backport two changes to 1.39.0 (rust-lang/cargo#7424)
Mark-Simulacrum pushed a commit to Mark-Simulacrum/rust that referenced this pull request Sep 26, 2019
2 commits in b6c6f685b38d523580813b0031677c2298f458ea..4b105b6abfb12d6985ffe66670e8b2a85982291a
2019-09-19 21:10:09 +0000 to 2019-09-25 17:26:54 +0000
- [beta] Don't ever capture CPU state if timings are disabled (rust-lang/cargo#7430)
- [beta] Backport two changes to 1.39.0 (rust-lang/cargo#7424)
@ehuss ehuss added this to the 1.39.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants