Tweak handling of aliases #5468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r=me, nice! |
|
@bors r=alexcrichton |
|
📌 Commit e4e3177 has been approved by |
|
⌛ Testing commit e4e31776f56307a68962e85020386083e7bfc1e0 with merge d25fb85f77e29053b54d4d12782411f15b019845... |
|
💔 Test failed - status-travis |
Previously, `execute_subcommand` was called recursively, and each call would `.configure` the `config` again. It worked, but seemed rather fragile. This commit handles aliases more explicitly, ensures that `.configure` is called once and, as a bonus, adds a warning for when an alias is shadowed by the built in.
By convention, all errors should start with a lowercase letter
|
@bors r=alexcrichton |
|
📌 Commit ecd1e5d has been approved by |
bors
added a commit
that referenced
this pull request
May 3, 2018
Tweak handling of aliases Previously, `execute_subcommand` was called recursively, and each call would `.configure` the `config` again. It worked, but seemed rather fragile. This commit handles aliases more explicitly, ensures that `.configure` is called once and, as a bonus, adds a warning for when an alias is shadowed by the built in.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
execute_subcommandwas called recursively, and each callwould
.configuretheconfigagain. It worked, but seemed ratherfragile.
This commit handles aliases more explicitly, ensures that
.configureis called once and, as a bonus, adds a warning for when an alias is
shadowed by the built in.