Windows environment variables are case preserving (but case-insensitive)

I recently submitted a PR to stop Rust ASCII upper casing environment variables: https://github.com/rust-lang/rust/pull/85270. This causes the following test to fail.

https://github.com/rust-lang/cargo/blob/36917524b96ebe701b5006b8773042dace8bca05/tests/testsuite/tool_paths.rs#L360-L373 

I think it's because something relies on a new process upper casing key names? Which only happened before because Rust manually ASCII upper cased keys when starting a new process.

---

Hm, that seems to be the assumption here:

https://github.com/rust-lang/cargo/blob/36917524b96ebe701b5006b8773042dace8bca05/src/cargo/util/config/mod.rs#L698-L703

Whereas Windows itself does no such conversion.

---

cc @ehuss ? (only because you most recently touched the relevant test 🙂)

	let target = rustc_host();
	let env_key = format!(
	"CARGO_TARGET_{}_LINKER",
	target.to_lowercase().replace('-', "_")
	);

	let mut execs = p.cargo("build -v --target");
	execs.arg(target).env(&env_key, "nonexistent-linker");
	if cfg!(windows) {
	// Windows env keys are case insensitive, so no warning, but it will
	// fail due to the missing linker.
	execs
	.with_stderr_does_not_contain("warning:[..]")
	.with_status(101);

	fn check_environment_key_case_mismatch(&self, key: &ConfigKey) {
	if cfg!(windows) {
	// In the case of windows the check for case mismatch in keys can be skipped
	// as windows already converts its environment keys into the desired format.
	return;
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Windows environment variables are case preserving (but case-insensitive) #9630

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Windows environment variables are case preserving (but case-insensitive) #9630

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions