-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Closed
Labels
A-patchArea: [patch] table overrideArea: [patch] table overrideC-feature-requestCategory: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`S-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewStatus: Issue or feature is accepted, and has a team member available to help mentor or review
Description
Describe the problem you are trying to solve
Often when [patch]
does not work for a user it is because there are newer versions available from the canonical source. Fixing this requires ether temporarily modifying the version of the replaced package or the requirement of the depending package. In ether case this probably needs to be un-done before upstreaming the fix.
Describe the solution you'd like
If a version is from the [patch]
section try it before versions from the canonical source, even if the patched package has a lower version. This is already what happens for versions that were in a lockfile, so it should not be hard to do.
Notes
We thought of this in a Cargo Team meeting, and I wanted to wright it down before we forgot.
weihanglo
Metadata
Metadata
Assignees
Labels
A-patchArea: [patch] table overrideArea: [patch] table overrideC-feature-requestCategory: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`S-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewStatus: Issue or feature is accepted, and has a team member available to help mentor or review