Optional Bindgen #126
Optional Bindgen #126
Conversation
Bumps to libonig to 6.9.3
Default features are specified with `features.default`.
|
Anything blocking that? |
|
Ping |
A dependency no longer supports 1.33.0. Seen as we are doing a minor version bump for this feature branch it is acceptable to bump this version. 1.33.0 is _quite old_. The switch to 1.34.0 seems acceptable.
Work around for feature handling bening broken causing CI failures. Part of #136
Generate feature was probably never tested in CI before. Looks like libclang-dev ins needed for this.
Hopefully this should include libclang in the path.
Installing dependencies for `bindgen` for CI builds.
Update the package dependencies from the `bindgen` documentation.
The dynamic bindgen feature appearntly is more tolerant of older llvm versions.
The `std::Pattern` API is chaing. Replace uses of now-deprecated items. Fixes #137
5f946b4 to
dfdcafb
Compare
Build and test each project individually to properly deal with feature flags in the windows builds. Fixes #136
Need to provide absolute paths otherwise we end up stuck in the `onig\` directory re-running the same build and test.
This doesn't seem to exist. Remove to fix nightly toolchain build failures.
Unstable features can't be used on stable channels. Update to test the `std-pattern` feature on beta.
Features aren't available on `beta`. My bad.
|
Just ran into this again, please requiring bindgen for endusers is a really unfortunate experience |
|
Is this not happening in the end? I'll fork it and release another version on crates.io if so |
|
I just find I don’t have the time to maintain this I’m sorry.
If be happy to add you as a maintainer to this project if you’d like rather
than forming the crate.
…On Thu, 30 Apr 2020 at 11:04, Vincent Prouillet ***@***.***> wrote:
Is this not happening in the end? I'll fork it and release another version
on crates.io if so
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#126 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHVG4OM4HCYXPAC56ZLPMDRPFEJPANCNFSM4I5XIZQQ>
.
|
|
What's missing? I can do a PR on that PR finish it. |
|
I'm sorry I can't remember the status of this PR. It looks like the build is failing though. I think that was the last thing I was struggling with. Something to do with how features and default features work with Cargo workspaces. Any PRs to help out would be appreciated, but so would help reviewing this stuff, reviewing PRs and pushing cargo packages too TBH. I do understand the frustration. I can't get |
|
#141 fixes the appveyor CI but I think the project needs to be moved to travis.com since it doesn't look like it even starts at all right now. I could move it to GH actions if that would be too annoying. |
|
I have GitHub actions working for OSX/linux in Keats#1 |
|
Can you add me as maintainer on the repo/crates.io so I can push it @iwillspeak ? |
Add GH actions
Fix the bindgen-take-two branch
|
I have the rights now, should it be 5.1.0 or 6.0.0 for the |
|
6.0 would be safest. |
|
I agree. Go for 6.
…On Fri, 15 May 2020 at 14:53, Kornel ***@***.***> wrote:
6.0 would be safest.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#126 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHVG4NUJRUZWVCLC3JUWBDRRVCMBANCNFSM4I5XIZQQ>
.
|
Pull xi-editor#126 allegedly fixed and superseded xi-editor#108. rust-onig/rust-onig#126
This PR aims to pull together the work in #108, and #113 and provide an ergonomic solution to the problem of gnerating correct bindings for any architecture which has an LLVM version while reducing or elmininating the dependency on
bindgenfor common build and CI scenarios.Fixes: #109, #123, #136.