-
Notifications
You must be signed in to change notification settings - Fork 49
Bundle pre-generated headers too #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This may fix #109 |
Thanks. I like the idea but i'd prefer this to be opt out rather than opt in for While I do like the upgrade to Rust 2018 could you move that part to a separate PR. Thanks again for the contribution. |
The main reason to avoid bindgen is the heavy libclang/llvm dependency. It makes it harder to install, and takes long time to compile. Unfortunately, env vars in Cargo can't disable dependencies. So even if it was controlled via an env flag, it'd still have the cost of system dependency and compile time. |
a8bcd16
to
67809a0
Compare
And is not really an option on Windows @ Azure Pipelines for example. I had to stick `syntect to a lower version to have CI working again. If it's not disabled by default, at least a feature that can be disabled like #113 would be great. |
I've rebased this branch. I've also changed dependency's |
Oh, my bad, sorry. |
Although I'm not a direct user of onig, it is in my dependency chain (of Tau, https://gitlab.gnome.org/World/Tau) and this PR has worked fine for me, avoiding me having to pull in lots of unnecessary deps. |
Hopefully I should have some time over the next few days to work on |
Bumps to libonig to 6.9.3
Closing in favor of #126. Thanks! |
Pulling in llvm is quite slow, and very problematic in many environments, so I've made runtime bindgen behind a feature flag.