Fix tz parse failure from out of bounds error #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the `index out of bounds` error that occurs when parsing some specific timezones. Tested by running the code to reproduce in #7 as well as compiling exa with zoneinfo-compiled containing this patch to confirm that `exa --long` doesn't panic.
|
I don't have much knowledge on zoneinfo files but this seems to fix the issue, and the downstream issue with exa, at least at the surface level. |
|
Oh my god, I spent like an hour debugging this problem today because I didn't see this PR! I've merged this because I prefer having those two expressions as variables now that I look at it. The good news is we ended up with pretty much the same solution: transition_type: flags_to_transition_type(tz.standard_flags.get(i).unwrap_or(&0) != &0,
tz.gmt_flags.get(i).unwrap_or(&0) != &0),I wanted to look up how the official zoneinfo code handles this case, and the code confirms that if those values are missing, they should be assumed to be 0: https://github.com/eggert/tz/blob/f9bd527016f806611e58a99d759d00c64c46a938/tzfile.h#L70-L80 Anyway, thanks for this. I'm going to publish a release today to fix the exa issue. |
|
v0.4.8 is out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
index out of boundserror that occurs when parsingsome specific timezones.
Tested by running the code to reproduce in #7 as well as compiling exa
with zoneinfo-compiled containing this patch to confirm that
exa --longdoesn't panic.Resolves #7
Relevant downstream ogham/exa#517