add some documentation clarifying the locktime ordering shenanigans in #1330 #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
reviewed
Dec 15, 2022
f1dda2d to
3131333
Compare
|
Done. |
Kixunil
previously approved these changes
Dec 15, 2022
tcharding
reviewed
Dec 15, 2022
bitcoin/CHANGELOG.md
Outdated
| total ordering on locktimes will be forced to wrap this type. In `Transaction`, which | ||
| contains a `LockTime` but is `Ord`, we have manually sorted the locktimes based on | ||
| their consensus encoding. This ordering is somewhat arbitrary -- there is no total | ||
| ordering on locktimes since they may be measured in either blocks or heights. |
There was a problem hiding this comment.
Suggested change
| ordering on locktimes since they may be measured in either blocks or heights. | |
| ordering on locktimes since they may be measured in either blocks or seconds. |
bitcoin/src/blockdata/transaction.rs
Outdated
| @@ -580,6 +580,19 @@ impl<E> EncodeSigningDataResult<E> { | |||
| /// | |||
| /// We therefore deviate from the spec by always using the Segwit witness encoding | |||
| /// for 0-input transactions, which results in unambiguously parseable transactions. | |||
| /// | |||
3131333 to
02c1cd6
Compare
|
Fixed Tobin's comments. |
tcharding
approved these changes
Dec 15, 2022
Kixunil
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the CHANGELOG and also the doccomment on
Transaction.