backport: Add XOnlyPublicKey support for PSBT key retrieval and improve Taproot signing #4443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @storopoli because he is waiting for this according to #4388 |
79a03fe to
74e2c5c
Compare
|
In 9331108: Why isn't it an API break to change the signature of the Also why isn't the API-break bot running here? (I guess we hadn't enabled it in the 0.32 branch in our CI directory? Can we do that?) |
|
74e2c5c looks good other than that one commit. |
storopoli
approved these changes
May 5, 2025
… signing This commit enhances PSBT signing functionality by: 1. Added new KeyRequest::XOnlyPubkey variant to support direct retrieval using XOnly public keys 2. Implemented GetKey for HashMap<XOnlyPublicKey, PrivateKey> for more efficient Taproot key management 3. Modified HashMap<PublicKey, PrivateKey> implementation to handle XOnlyPublicKey requests by checking both even and odd parity variants These changes allow for more flexible key management in Taproot transactions. Specifically, wallet implementations can now store keys indexed by either PublicKey or XOnlyPublicKey and successfully sign PSBTs with Taproot inputs. Added tests for both implementations to verify correct behavior. Added test for odd parity key retrieval. Closes rust-bitcoin#4150
74e2c5c to
95eb255
Compare
Ooph - fail! Thanks man. Force push includes a few things:
|
|
cc @shesek in case you wanted to see your bug fix getting released. Should have been backported immediately that it was done, my bad. |
storopoli
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport two PRs:
The first includes a bug fix in a
GetKeyimpl and the second is a feature we want to release. And the three refactor patches touch code that #4238 builds on so I figured we should backport them all.All 5 patches required a small amount of massaging to get in. The first 4 was just adding a
?to the calls toderive_priv. The last patch needed a few calls in the unit test changing.