Enable getting the network kind from an address #4251
Conversation
|
This patch can be trivially backported to the 0.32.x branch with |
Users may wish to ask of an address 'what kind of address is this?' We have the `NetworkKind` struct that abstracts over the answer but currently no API to ask the question. The address may have been parsed or constructed and weather the network has been checked already is immaterial. Hence we add the function for both `NetworkChecked` and `NetworkUnchecked` addresses. Fix: rust-bitcoin#4247
147afd8 to
f4f79f8
Compare
| KnownHrp::Regtest => NetworkKind::Test, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I feel somewhat uneasy about this conversion since it's lossy. But not really wrong.
There was a problem hiding this comment.
KnownHrp is a larger type than NetworkKind so it's in the type signature that it'll be lossy.
| P2sh { hash: _, ref network } => *network, | ||
| Segwit { program: _, ref hrp } => NetworkKind::from(*hrp), | ||
| } | ||
| } |
There was a problem hiding this comment.
Might be worth also having is_mainnet method (and possibly also is_a_test).
There was a problem hiding this comment.
I'm leaning toward not because these methods are one-liners (once this method is in) and it's extra API surface.
There was a problem hiding this comment.
Well, these are common in Rust libraries. But maybe it's enough to have them on NetworkKind so once can call network_kind().is_mainnet().
Users may wish to ask of an address 'what kind of address is this?' We have the
NetworkKindstruct that abstracts over the answer but currently no API to ask the question.The address may have been parsed or constructed and weather the network has been checked already is immaterial. Hence we add the function for both
NetworkCheckedandNetworkUncheckedaddresses.Fix: #4247