… macro Array implementations e744347 Make usage of Self and type uniform across both modules (Erick Cestari) dfb49f0 Rename impl_try_from_array to impl_from_array (Erick Cestari) Pull request description: This PR makes two main changes: 1. Standardizes the function signatures in the `Amount` and `SignedAmount` implementations by consistently using `Self` as the return type instead of the concrete type names. This improves code consistency, maintainability, and follows Rust's idiomatic practices. 2. Renames `impl_try_from_array` to `impl_from_array` to better reflect its functionality. ### Changes **Consistent usage of Self instead of concrete types** - Replace all occurrences of `-> Amount` with `-> Self `in unsigned.rs - Replace all occurrences of `-> SignedAmount` with `-> Self` in signed.rs - Make similar replacements for Option/Result return types - Use `Self::` instead of explicit type name for static method calls **Function rename** Renamed `impl_try_from_array` to `impl_from_array` for better clarity ### Related Issues Closes rust-bitcoin#4210 Closes rust-bitcoin#4241 ACKs for top commit: Kixunil: ACK e744347 tcharding: ACK e744347 apoelstra: ACK e744347; successfully ran local tests Tree-SHA512: 3113f3ccf595b298afe6b23514f1de790284df7fcb55a13658aabe3ef4fcea0e401b65b0a2c67ac18da87a1bcd247bd1f1484856fe03470b98dfa2614958a3bb

The impl_try_from_array macro is named incorrectly #4241

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

The `impl_try_from_array` macro is named incorrectly #4241