Skip to content

Conversation

yoshuawuyts
Copy link
Collaborator

Tests were failing. This makes it pass. Thanks!

@yoshuawuyts yoshuawuyts changed the title fix examples (wip) fix examples Apr 17, 2018
@yoshuawuyts yoshuawuyts changed the title (wip) fix examples (wip) fix test failures Apr 17, 2018
@yoshuawuyts
Copy link
Collaborator Author

yoshuawuyts commented Apr 17, 2018

breaking change; full minor release required (not just patch) because we changed a type parameter on a pub function to please clippy.

@killercup
Copy link
Collaborator

breaking change; full minor release required (not just patch) because we changed a type parameter on a pub function to please clippy.

Yes, we should do this. But I we didn't want to… https://play.rust-lang.org/?gist=eb8a9de6e35a7874844d66e6260c743c&version=stable

@killercup killercup mentioned this pull request Apr 17, 2018
@killercup killercup merged commit 82ebdcc into master Apr 17, 2018
@yoshuawuyts yoshuawuyts deleted the fix-example branch April 17, 2018 12:01
epage added a commit that referenced this pull request Oct 6, 2023
…holder

README.md 'Crates Status' icon link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants