Add support RuboCop::AST::Node#any_def_type? method
#377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d5da93 to
dbf3ced
Compare
This PR adds support for `RuboCop::AST::Node#any_def_type?` method, which abstracts over the `def` and `defs` node types.
dbf3ced to
4502517
Compare
|
👍 I also think this makes sense. I though about adding this myself in the past but couldn't find a good name. There are many places in RuboCop than can make use of this, from just a basic search for |
koic
added a commit
to rubocop/rubocop
that referenced
this pull request
Apr 3, 2025
koic
added a commit
to rubocop/rubocop-rails
that referenced
this pull request
Apr 3, 2025
Follow-up to rubocop/rubocop-ast#377 This PR suppresses the following new offenses: ```console $ bundle exec rubocop (snip) lib/rubocop/cop/rails/three_state_boolean_column.rb:48:43: C: [Correctable] InternalAffairs/NodeTypeGroup: Use :any_def instead of individually listing group types. def_node = node.each_ancestor(:def, :defs).first ^^^^^^^^^^^ 301 files inspected, 1 offense detected, 1 offense autocorrectable ```
koic
added a commit
to rubocop/rubocop-performance
that referenced
this pull request
Apr 3, 2025
Follow-up to rubocop/rubocop-ast#377 This PR suppresses the following new offenses: ```console $ bundle exec rubocop -a (snip) Offenses: lib/rubocop/cop/performance/block_given_with_explicit_block.rb:39:41: C: [Correctable] InternalAffairs/NodeTypeGroup: Use :any_def instead of individually listing group types. def_node = node.each_ancestor(:def, :defs).first ^^^^^^^^^^^ lib/rubocop/cop/performance/regexp_match.rb:242:28: C: [Correctable] InternalAffairs/NodeTypeGroup: Use :any_def instead of individually listing group types. ancestor.type?(:def, :defs, :class, :module) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 122 files inspected, 2 offenses detected, 2 offenses autocorrectable ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
RuboCop::AST::Node#any_def_type?method, which abstracts over thedefanddefsnode types.